Add non-parameter attribute rendering #135
Conversation
|
Thank you! I'd like the opinion of @TimWolla and @kocsismate about the generated XHTML |
|
I don't have an opinion. I trust that you generate XHTML that looks good 😄 |
|
Function attributes were not rendering properly and there was no test for them either so I just pushed a commit to fix this. |
|
Attributes of class, exception and interface synopses are rendering like this:
|
|
Attributes of methods
and functions
|
|
I would prefer having a newline between every attribute as well. |
Something like in the below screenshots? Classes/exceptions/interfaces: Methods: Functions: |
Yes, looks great to me. Thank you. |
Enable rendering of attributes for classes, exceptions, interfaces, methods and functions.
haszi
force-pushed
the
Add-non-parameter-attribute-rendering
branch
from
e434d42
to
e74ff2e
Compare
|
I've just pushed the commit to render every attribute on its own line (just like in the last set of screenshots). |
|
Thank you! I'll implement the required gen_stub.php related changes |
Enable rendering of attributes for classes, exceptions, interfaces, methods and functions. The implementation feels a little off but it seems to work as intended (see attached test
attribute_formatting_002.phpt).I've also found a mistake I've made in the test
attribute_formatting_001.phptwhere the parameter attribute was outside of the<methodparam>element. I've corrected this by moving the attribute inside the element.